Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Migrate csra to 1.x #1177

Merged
merged 10 commits into from
Nov 21, 2022
Merged

[Feature] Migrate csra to 1.x #1177

merged 10 commits into from
Nov 21, 2022

Conversation

yingfhu
Copy link
Collaborator

@yingfhu yingfhu commented Nov 8, 2022

Motivation

Migrate CSRA to 1.x.

Modification

Add metrics VOCMultiLabelMetric and VOCAveragePrecision for VOC dataset because of the difficult attribute in objects.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@yingfhu yingfhu requested a review from Ezra-Yu November 8, 2022 10:51
@yingfhu yingfhu changed the title Add csra 1x [Feat] Migrate csra to 1.x Nov 8, 2022
@yingfhu yingfhu changed the title [Feat] Migrate csra to 1.x [Feature] Migrate csra to 1.x Nov 8, 2022
@yingfhu yingfhu added the 1.0rc Functionalities for MMClassification 1.0rc label Nov 8, 2022
@yingfhu yingfhu requested a review from Ezra-Yu November 16, 2022 05:37
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 0.02% // Head: 90.06% // Increases project coverage by +90.03% 🎉

Coverage data is based on head (3c0b786) compared to base (b8b31e9).
Patch has no changes to coverable lines.

❗ Current head 3c0b786 differs from pull request most recent head 090bd38. Consider uploading reports for the commit 090bd38 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1177       +/-   ##
============================================
+ Coverage     0.02%   90.06%   +90.03%     
============================================
  Files          121      142       +21     
  Lines         8217    10467     +2250     
  Branches      1368     1656      +288     
============================================
+ Hits             2     9427     +9425     
+ Misses        8215      820     -7395     
- Partials         0      220      +220     
Flag Coverage Δ
unittests 90.06% <ø> (+90.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 0.00% <0.00%> (ø)
mmcls/datasets/transforms/compose.py
mmcls/models/backbones/mvit.py 92.46% <0.00%> (ø)
mmcls/structures/utils.py 77.77% <0.00%> (ø)
mmcls/models/retrievers/__init__.py 100.00% <0.00%> (ø)
mmcls/models/heads/multi_label_csra_head.py 40.54% <0.00%> (ø)
mmcls/models/backbones/efficientformer.py 95.08% <0.00%> (ø)
mmcls/models/classifiers/hugging_face.py 25.33% <0.00%> (ø)
mmcls/engine/hooks/retriever_hooks.py 72.72% <0.00%> (ø)
mmcls/models/heads/efficientformer_head.py 93.10% <0.00%> (ø)
... and 132 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mzr1996 mzr1996 merged commit 629f644 into open-mmlab:dev-1.x Nov 21, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* [Feat] add csra to 1x

* minor fix

* add voc metrics

* refine

* add unittest

* minor fix

* add more comments

* Fix docs and metafile.

* Fix docs.

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0rc Functionalities for MMClassification 1.0rc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants