-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor to use new fileio API in MMEngine. #1176
Conversation
Codecov ReportBase: 0.02% // Head: 91.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1176 +/- ##
============================================
+ Coverage 0.02% 91.11% +91.09%
============================================
Files 121 138 +17
Lines 8217 10221 +2004
Branches 1368 1611 +243
============================================
+ Hits 2 9313 +9311
+ Misses 8215 687 -7528
- Partials 0 221 +221
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to use backend.join_path
instead of join_path
since join_path
already uses enable_singleton=True
.
The time saving might be marginal and is only for load annotations at the beginning, which is not affecting training data time.
use join_path
seems more unified. Otherwise comments must be added for those use backend.join_path
for better understanding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [Refactor] Refactor to use new fileio API in MMEngine. * Add comment about why use `backend`
Remove all
FileClient
and use the new API in MMEngine.