Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fixed typo in pytorch2torchscript.md #1173

Merged

Conversation

unseenme
Copy link

@unseenme unseenme commented Nov 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fixed typo in pytorch2torchscript.md

Modification

Before:
python tools/deployment/pytorch2onnx.py
After:
python tools/deployment/pytorch2torchscript.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2022

CLA assistant check
All committers have signed the CLA.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Nov 8, 2022

please fix the lint, refer to this doc. If you have any questions, please feel free to contact us.

@unseenme
Copy link
Author

unseenme commented Nov 8, 2022

please fix the lint, refer to this doc. If you have any questions, please feel free to contact us.

Thank you for your comment. Why there is a warning in the file which I haven't changed?

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Nov 8, 2022

Sorry that, it seems to be a legacy, And could you fix it in this PR, refer to https://mmclassification.readthedocs.io/en/latest/community/CONTRIBUTING.html#code-style

in $MMCls

  1. install pre-commit
pip install -U pre-commit
pre-commit install

2 run pre-commit run --all-files twice, it will fix the lint automaticly.
3. use git to add; commit; push.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 86.02% // Head: 86.02% // No change to project coverage 👍

Coverage data is based on head (ef0da3f) compared to base (aacaa73).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1173   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files         142      142           
  Lines        9906     9906           
  Branches     1715     1715           
=======================================
  Hits         8522     8522           
  Misses       1122     1122           
  Partials      262      262           
Flag Coverage Δ
unittests 85.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/dataset_wrappers.py 71.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mzr1996 mzr1996 merged commit 4a3ad4f into open-mmlab:master Nov 9, 2022
@unseenme unseenme deleted the unseenme-fixed_typo_in_pytorch2torchscript branch April 23, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants