Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Activation Checkpointing for ConvNeXt #1152

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Nov 1, 2022

Support Activation Checkpointing for ConvNeXt

Followed the code pattern of SwinTransformer.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 86.09% // Head: 86.03% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (72100e4) compared to base (91b85bb).
Patch coverage: 85.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1152      +/-   ##
==========================================
- Coverage   86.09%   86.03%   -0.06%     
==========================================
  Files         142      142              
  Lines        9895     9913      +18     
  Branches     1612     1716     +104     
==========================================
+ Hits         8519     8529      +10     
- Misses       1114     1122       +8     
  Partials      262      262              
Flag Coverage Δ
unittests 85.96% <85.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/convnext.py 95.08% <85.00%> (+0.29%) ⬆️
mmcls/utils/distribution.py 7.40% <0.00%> (-3.12%) ⬇️
mmcls/apis/train.py 15.00% <0.00%> (-0.39%) ⬇️
mmcls/datasets/samplers/distributed_sampler.py 85.71% <0.00%> (+0.52%) ⬆️
mmcls/models/backbones/timm_backbone.py 87.23% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Nov 1, 2022

please fix the lint.

@nijkah
Copy link
Contributor Author

nijkah commented Nov 1, 2022

Hi @Ezra-Yu , should I create a new PR for dev-1.x?

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Nov 1, 2022

Hi @Ezra-Yu , should I create a new PR for dev-1.x?

Yes, welcome!

@nijkah nijkah changed the title Support Activation Checkpointing for ConvNeXt [Feature] Support Activation Checkpointing for ConvNeXt Nov 1, 2022
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 05e4bc1 into open-mmlab:dev Nov 14, 2022
@nijkah nijkah deleted the convnext_checkpoint branch November 14, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants