Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the torchserve #1143

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Conversation

marouaneamz
Copy link
Contributor

@marouaneamz marouaneamz commented Oct 26, 2022

Modification

after our discussion in #1141 I just changed mmcv to mmengine to mmcls2torchserve.

  1. fix torch serve;
  2. remove deprecated deploy tools.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@marouaneamz
Copy link
Contributor Author

marouaneamz commented Oct 26, 2022

@Ezra-Yu In my understanding, the default _scope for the registry will be initialized in the runner. to use inference-mmcls in deploy servers it must be run with runners or hardcoded default_scope.

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Oct 28, 2022

@marouaneamz Some other places also need to be modified.
Can I make some modifications and push it to your branch?

@marouaneamz
Copy link
Contributor Author

@Ezra-Yu yes of course.

@Ezra-Yu Ezra-Yu changed the title change mmcv to mmengine in mmcls2torchserve [Fix] Fix the torchserve Oct 28, 2022
@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Oct 31, 2022

@marouaneamz Sorry, I have no permission to push code into your repo. Can you invite me to cooperate with your repo.?
refer to this GitHub doc.

@marouaneamz
Copy link
Contributor Author

@Ezra-Yu i invite you to my repository can you check it is good

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 0.02% // Head: 89.02% // Increases project coverage by +88.99% 🎉

Coverage data is based on head (ac0586e) compared to base (b8b31e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1143       +/-   ##
============================================
+ Coverage     0.02%   89.02%   +88.99%     
============================================
  Files          121      146       +25     
  Lines         8217    11149     +2932     
  Branches      1368     1771      +403     
============================================
+ Hits             2     9925     +9923     
+ Misses        8215      974     -7241     
- Partials         0      250      +250     
Flag Coverage Δ
unittests 89.02% <ø> (+88.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 0.00% <0.00%> (ø)
mmcls/datasets/transforms/compose.py
mmcls/models/utils/layer_scale.py 86.66% <0.00%> (ø)
mmcls/models/heads/efficientformer_head.py 93.10% <0.00%> (ø)
mmcls/models/backbones/swin_transformer_v2.py 89.63% <0.00%> (ø)
mmcls/models/heads/arcface_head.py 85.48% <0.00%> (ø)
mmcls/models/retrievers/base.py 100.00% <0.00%> (ø)
mmcls/models/backbones/davit.py 84.94% <0.00%> (ø)
mmcls/evaluation/metrics/voc_multi_label.py 100.00% <0.00%> (ø)
mmcls/engine/optimizers/adan_t.py 10.60% <0.00%> (ø)
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu Ezra-Yu changed the base branch from 1.x to dev-1.x November 16, 2022 01:55
@mzr1996 mzr1996 merged commit 743ca2d into open-mmlab:dev-1.x Nov 21, 2022
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* rebase

* update docker and rm deprecated deployment tools

* update docs

* rebase

Co-authored-by: Ezra-Yu <18586273+Ezra-Yu@users.noreply.github.com>
@marouaneamz marouaneamz deleted the 1.x_deployment branch January 13, 2023 23:48
@OpenMMLab-Assistant005
Copy link

Hi @marouaneamz !First of all, we want to express our gratitude for your significant PR in the MMCls project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants