Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MobileViT #1068

Merged
merged 11 commits into from
Oct 18, 2022
Merged

Support MobileViT #1068

merged 11 commits into from
Oct 18, 2022

Conversation

yingfhu
Copy link
Collaborator

@yingfhu yingfhu commented Sep 30, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

mmcls/models/backbones/mobilevit.py Outdated Show resolved Hide resolved
mmcls/models/backbones/mobilevit.py Outdated Show resolved Hide resolved
configs/mobilevit/metafile.yml Outdated Show resolved Hide resolved
'../_base_/schedules/imagenet_bs256.py',
]

# no normalize for original implements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since no normalize, why the std is 255 instead of 1.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std=1 all pixels fall into range 0-255, in original repo,input should be in range 0-1

configs/mobilevit/mobilevit-small_8xb128_in1k.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 0.02% // Head: 91.35% // Increases project coverage by +91.33% 🎉

Coverage data is based on head (65308ea) compared to base (b8b31e9).
Patch has no changes to coverable lines.

❗ Current head 65308ea differs from pull request most recent head 5dc9a94. Consider uploading reports for the commit 5dc9a94 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1068       +/-   ##
============================================
+ Coverage     0.02%   91.35%   +91.33%     
============================================
  Files          121      130        +9     
  Lines         8217     9776     +1559     
  Branches      1368     1539      +171     
============================================
+ Hits             2     8931     +8929     
+ Misses        8215      649     -7566     
- Partials         0      196      +196     
Flag Coverage Δ
unittests 91.35% <ø> (+91.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 0.00% <0.00%> (ø)
mmcls/datasets/transforms/compose.py
mmcls/models/utils/layer_scale.py 86.66% <0.00%> (ø)
mmcls/models/backbones/swin_transformer_v2.py 89.47% <0.00%> (ø)
mmcls/models/backbones/edgenext.py 95.20% <0.00%> (ø)
mmcls/structures/utils.py 77.77% <0.00%> (ø)
mmcls/models/backbones/mobilevit.py 91.15% <0.00%> (ø)
mmcls/models/heads/efficientformer_head.py 93.10% <0.00%> (ø)
mmcls/models/backbones/mvit.py 92.46% <0.00%> (ø)
mmcls/models/backbones/deit3.py 94.52% <0.00%> (ø)
... and 120 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mzr1996 mzr1996 merged commit bcca619 into open-mmlab:dev-1.x Oct 18, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* init

* fix

* add config

* add meta

* add unittest

* fix for comments

* Imporvee docstring and support custom arch.

* Update README

* Update windows CI

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants