Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] RepVGG for YOLOX-PAI #1025

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

okotaku
Copy link
Collaborator

@okotaku okotaku commented Sep 13, 2022

Motivation

Add MTSPPF block and add_ppf param for YOLOX-PAI.
YOLOX-PAI: An Improved YOLOX, Stronger and Faster than YOLOv6
official repo

Modification

  1. add MTSPPF module and support it in RepVGG backbone;
  2. support 'stem_channels' in arch and add a 'yolox-pai-small' arch cfg
  3. Reduce the number of channels to speed up unit testing

Related PR

open-mmlab/mmdetection#8778

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@okotaku okotaku changed the title repvgg add ppf for yoloxpai [Enhancement] RepVGG for YOLOX-PAI Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 86.09% // Head: 86.09% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e4881a6) compared to base (517bd3d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1025      +/-   ##
==========================================
- Coverage   86.09%   86.09%   -0.01%     
==========================================
  Files         140      142       +2     
  Lines        9676     9896     +220     
  Branches     1677     1713      +36     
==========================================
+ Hits         8331     8520     +189     
- Misses       1092     1114      +22     
- Partials      253      262       +9     
Flag Coverage Δ
unittests 86.02% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/repvgg.py 96.15% <100.00%> (-0.69%) ⬇️
mmcls/apis/train.py 15.38% <0.00%> (ø)
mmcls/models/backbones/van.py 96.83% <0.00%> (ø)
mmcls/models/utils/__init__.py 100.00% <0.00%> (ø)
mmcls/models/utils/attention.py 96.91% <0.00%> (ø)
mmcls/models/backbones/__init__.py 100.00% <0.00%> (ø)
mmcls/models/backbones/hornet.py 83.07% <0.00%> (ø)
mmcls/models/utils/layer_scale.py 86.66% <0.00%> (ø)
mmcls/models/backbones/t2t_vit.py 95.18% <0.00%> (+0.05%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmcls/models/backbones/repvgg.py Outdated Show resolved Hide resolved
@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Sep 27, 2022

>>> from mmcls.models.backbones import RepVGG
>>> model = RepVGG('yolox-pai-small', out_indices=(1, 2, 3, ), add_ppf=True )

Is this model what you want? @okotaku

@okotaku
Copy link
Collaborator Author

okotaku commented Sep 27, 2022

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -262,17 +309,24 @@ class RepVGG(BaseBackbone):
<https://arxiv.org/abs/2101.03697>`_

Args:
arch (str | dict): The parameter of RepVGG.
If it's a dict, it should contain the following keys:
arch (str | dict): Swin Transformer architecture. If use string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RepVGG architecture.

@mzr1996 mzr1996 merged commit 8c7b7b1 into open-mmlab:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants