Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support get_ppl for TurbomindModel #878

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Support get_ppl for TurbomindModel #878

merged 4 commits into from
Mar 6, 2024

Conversation

RunningLeon
Copy link
Contributor

@RunningLeon RunningLeon commented Feb 6, 2024 •
edited
Loading

Motivation

Support get_ppl for TurbomindModel

Modification

  • add get_ppl for TurbomindModel
  • add end_str and remove unused path arument for TurboMindAPIModel

BC-breaking (Optional)

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@RunningLeon
Copy link
Contributor Author

@lvhan028 @AllentDan hi, guys. Could you take a minute to review this PR? THX.

@RunningLeon
Copy link
Contributor Author

@bittersweet1999 hi, when will this PR be merged?

@Leymore Leymore merged commit c54a5d3 into open-compass:main Mar 6, 2024
9 checks passed
Leymore pushed a commit that referenced this pull request Apr 23, 2024
@RunningLeon @BunnyRunnerX
Support get_ppl for TurbomindModel (#878)
3b82d1c 
* update ppl for turbomindmodel

* update api_server

* rename config and set thread_safe for pytorch engine if possible
liuyaox pushed a commit to liuyaox/opencompass that referenced this pull request Jun 26, 2024
@RunningLeon
Support get_ppl for TurbomindModel (open-compass#878)
7cc2d37 
* update ppl for turbomindmodel

* update api_server

* rename config and set thread_safe for pytorch engine if possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leymore Leymore Leymore approved these changes

@AllentDan AllentDan AllentDan approved these changes

@bittersweet1999 bittersweet1999 bittersweet1999 approved these changes

Assignees

@bittersweet1999 bittersweet1999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RunningLeon @Leymore @AllentDan @bittersweet1999