Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calm dataset #1287

Merged
merged 16 commits into from
Jul 26, 2024
Merged

Calm dataset #1287

merged 16 commits into from
Jul 26, 2024

Conversation

pengbo807
Copy link
Contributor

@pengbo807 pengbo807 commented Jul 4, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@liushz
Copy link
Collaborator

liushz commented Jul 8, 2024

image 目前跑出来的结果展示有点冗长,可以考虑添加summarizer来展示重点内容

@pengbo807
Copy link
Contributor Author

Thank you for your feedback. I've updated the pull request to include the summarizer functionality as suggested. Specifically:

  • Added a summarizer option to provide concise output with average information for all tasks
  • The summarizer can be activated using the --summarizer calm flag
  • Without this flag, the script will continue to provide detailed task-specific information

Please review the updates and let me know if any further modifications are needed.

Copy link
Collaborator

@liushz liushz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bittersweet1999 bittersweet1999 merged commit edd0ffd into open-compass:main Jul 26, 2024
8 of 9 checks passed
bittersweet1999 added a commit that referenced this pull request Jul 26, 2024
bittersweet1999 added a commit that referenced this pull request Jul 26, 2024
@bittersweet1999
Copy link
Collaborator

we revert this PR because of the lint problem, please reopen this PR

pengbo807 added a commit to pengbo807/opencompass that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants