Add FallVelocity attribute and RelaxedVelocity dynamic (and tests)
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `RelaxedVelocity` dynamic
…y uses RogersYau approx by default
remove unused import
add relaxed velocity option to Gravitational, Geometric, and Parameterized collision kernels
(we could also make a "terminal momentum" attribute but I'm not sure if it would have any use)
…_dummy_attribute_factory
…onsistency on CI)
|
trying if closing and reopening would sort out |
slayoo
previously approved these changes
Jul 27, 2023
|
@bradybhalla I've just committed a few cosmetic changes - please have a look and confirm it that is all OK, and let's merge! |
|
It looks great to me! Thank you for all your help getting the code ready to merge! |
slayoo
approved these changes
Jul 27, 2023
|
Just added one more unit test (checking if a warning is issued by |
slayoo
added a commit
to mikhailmints/PySDM
that referenced
this pull request
Aug 17, 2023
open-atmos#1105) Co-authored-by: Sylwester Arabas <sylwester.arabas@agh.edu.pl> Co-authored-by: Sylwester Arabas <sylwester.arabas@uj.edu.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows droplets to have a memory of their current velocity and tend towards their terminal velocity over a relaxation timescale. Adds a parameter for existing dynamics to use this attribute instead of terminal velocity. Also includes unit tests for the attribute, dynamic, and initialisation function.
This will allow simulation of super-terminal and sub-terminal droplets as discussed in this paper.
With help from @edejong-caltech.