-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FallVelocity
attribute and RelaxedVelocity
dynamic (and tests)
#1105
Conversation
…e `RelaxedVelocity` dynamic
…y uses RogersYau approx by default
remove unused import
add relaxed velocity option to Gravitational, Geometric, and Parameterized collision kernels
(we could also make a "terminal momentum" attribute but I'm not sure if it would have any use)
…_dummy_attribute_factory
…onsistency on CI)
trying if closing and reopening would sort out |
@bradybhalla I've just committed a few cosmetic changes - please have a look and confirm it that is all OK, and let's merge! |
It looks great to me! Thank you for all your help getting the code ready to merge! |
Just added one more unit test (checking if a warning is issued by |
open-atmos#1105) Co-authored-by: Sylwester Arabas <sylwester.arabas@agh.edu.pl> Co-authored-by: Sylwester Arabas <sylwester.arabas@uj.edu.pl>
Allows droplets to have a memory of their current velocity and tend towards their terminal velocity over a relaxation timescale. Adds a parameter for existing dynamics to use this attribute instead of terminal velocity. Also includes unit tests for the attribute, dynamic, and initialisation function.
This will allow simulation of super-terminal and sub-terminal droplets as discussed in this paper.
With help from @edejong-caltech.