Support ver 7 #193
Merged
Support ver 7 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/support_status.md # onnx_tf/opset_version.py
|
Huh, so if I understand correctly, since TF conforms with NP style broadcasting, we don't need to do anything special about broadcasting in version 7 right? |
|
On a separate note, can you comment why we should use cls.make_node instead of the helper.make_node from ONNX (i.e., here ). I don't have any problem with it, but we may want to document design choice as we go along because we may forget them in the future. |
|
Yes, we don't need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure to use
_limited_broadcastand_np_broadcastis a good idea.They changed broadcast mechanism to as same as numpy from since version 7.
Also fix the tile version, from 1 to 6. 1 is not implemented yet.