Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

support the random generator ops and fix the issues on tf.op #453

Merged
merged 4 commits into from
Apr 24, 2020
Merged

support the random generator ops and fix the issues on tf.op #453

merged 4 commits into from
Apr 24, 2020

Conversation

wenbingl
Copy link
Member

No description provided.

@wenbingl wenbingl requested a review from jiafatom April 23, 2020 01:22
@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2020

This pull request introduces 1 alert when merging 3e30c6b into 74e855a - view on LGTM.com

new alerts:

  • 1 for Unused import

jiafatom
jiafatom reviewed Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@jiafatom jiafatom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we make sure the correctness of random generator ops? Since it is random, the result can be random for tf ops and onnx ops. Therefore can it guarantee equal?

@wenbingl
Copy link
Member Author

How can we make sure the correctness of random generator ops? Since it is random, the result can be random for tf ops and onnx ops. Therefore can it guarantee equal?

There is an attr called 'seed'.

@jiafatom jiafatom merged commit 3d013c7 into onnx:master Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jiafatom jiafatom jiafatom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenbingl @jiafatom