Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonjour constructor options type does not match mDNS options type (missing interface field) #52

Open
JensEggers opened this issue Jun 17, 2024 · 1 comment

Comments

@JensEggers
Copy link

mDNS can be bound to a specified network interface via the interface property in its Options type (see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/multicast-dns/index.d.ts#L58). This field is not present in the ServiceConfig type, and so we're not able to bind Bonjour to a particular adapter.

This could be fixed in one of two ways:

  • add an interface field to ServiceConfig (though I'm not sure this is applicable to bonjour services)
  • create a new options type for configuring Bonjour itself (ServiceConfig may not be the appropriate type, but perhaps rather mDNS:Options)
@JensEggers JensEggers changed the title Bonjour constructor options type does not match mDNS optinos type (missing interface field) Bonjour constructor options type does not match mDNS options type (missing interface field) Jun 17, 2024
@JensEggers
Copy link
Author

it turns out that Node.js doesn't appear to receive multicast messages on UDP sockets bound to particular adapters, so the need to specify an adapter becomes irrelevant. This issue can probably close for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant