Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for ClangCl on MSVC #2115

Open
emmenlau opened this issue Apr 14, 2022 · 4 comments
Open

Feature request: Add support for ClangCl on MSVC #2115

emmenlau opened this issue Apr 14, 2022 · 4 comments

Comments

@emmenlau
Copy link

Describe the bug
It would be great if oneDAL could be compiled with the clang-cl compiler frontend for Visual Studio. I have tried to use ClangCl but there seem to be some warnings or errors that make the build fail. Since ClangCl is very similar to clang but also to Visual Studio, it seems it is well aligned with the already supported compilers. And on Windows it generates often much faster code than Visual Studio alone.

@PivovarA PivovarA self-assigned this May 23, 2022
@napetrov
Copy link
Contributor

napetrov commented Jan 5, 2023

@emmenlau - is this request for library build with clang-cl?

@emmenlau
Copy link
Author

emmenlau commented Jan 5, 2023

@napetrov yes correct, I'd like to build the library with clang-cl from LLVM, as a frontend to Visual Studio.

@napetrov
Copy link
Contributor

napetrov commented Jan 5, 2023

@emmenlau - the way how some optimizations are enabled is based on use of compiler intrinsics and some portions of code would be accusable only in case compiler by Intel compilers. So non intel compilers likely would get lower perf comparing to version build with Intel compiler.

But overall would see if ClangCL can be added

@emmenlau
Copy link
Author

@napetrov what you say sounds very reasonable! Would love to have ClangCl added (even with these limitations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants