Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to package.json. #28

Merged
merged 4 commits into from
Dec 2, 2016
Merged

Add files to package.json. #28

merged 4 commits into from
Dec 2, 2016

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Saves ~2.5 KB when published to NPM.

@omnidan
Copy link
Owner

omnidan commented Dec 2, 2016

@wtgtybhertgeghgtwtg Thanks for the PR! Doesn't this mean that index.js will be excluded? If yes, the main field will need to be adjusted too.

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

I can't believe I forgot that, thank you so much for catching it. Would you prefer index.js to be included or main to point to lib/emoji, in which case index.js can be deleted?

@omnidan
Copy link
Owner

omnidan commented Dec 2, 2016

@wtgtybhertgeghgtwtg pointing main to lib/emoji.js directly would probably be the best way to go about this, then index.js can be deleted

@omnidan omnidan merged commit 6b2379d into omnidan:master Dec 2, 2016
@omnidan
Copy link
Owner

omnidan commented Dec 2, 2016

Thank you 😁

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

Thank you for merging. Sorry it took four commits to get it right.

@omnidan
Copy link
Owner

omnidan commented Dec 2, 2016

no problem 😉 released 1.4.2 with this change

omnidan added a commit that referenced this pull request Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants