Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs.pop() with conflicting defaults not setting the conditional default #364

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

mauvilsa
Copy link
Member

What does this PR do?

Fixes #362

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the bug Something isn't working label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cd165e9) 100.00% compared to head (a4363e0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         5715      5715           
=========================================
  Hits          5715      5715           
Flag Coverage Δ
py3.10 87.62% <100.00%> (ø)
py3.10_all 98.84% <100.00%> (ø)
py3.10_types 98.84% <100.00%> (ø)
py3.11 87.61% <100.00%> (ø)
py3.11_all 98.82% <100.00%> (ø)
py3.11_types 98.82% <100.00%> (ø)
py3.6 85.06% <100.00%> (+0.07%) ⬆️
py3.6_all 96.64% <100.00%> (+0.01%) ⬆️
py3.7 88.15% <100.00%> (ø)
py3.7_all 99.52% <100.00%> (ø)
py3.7_types 99.50% <100.00%> (ø)
py3.8 88.32% <100.00%> (ø)
py3.8_all 99.59% <100.00%> (ø)
py3.8_types 99.58% <100.00%> (ø)
py3.9 88.18% <100.00%> (ø)
py3.9_all 99.49% <100.00%> (ø)
py3.9_types 99.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jsonargparse/_parameter_resolvers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauvilsa mauvilsa force-pushed the issue-362-ast-conditional-pop branch from 27dfddd to a4363e0 Compare August 31, 2023 02:45
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mauvilsa mauvilsa merged commit 4148f4e into main Aug 31, 2023
16 checks passed
@mauvilsa mauvilsa deleted the issue-362-ast-conditional-pop branch August 31, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instantiation fails with TypeError only when fail_untyped=False
1 participant