Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is PackageId opaque but SourceId not? #237

Closed
weihanglo opened this issue Jun 26, 2023 · 1 comment · Fixed by #238
Closed

Why is PackageId opaque but SourceId not? #237

weihanglo opened this issue Jun 26, 2023 · 1 comment · Fixed by #238

Comments

@weihanglo
Copy link
Contributor

In rust-lang/cargo#12313, the Cargo team is discussing PackageId and SourceId should be seen as being opaque. We found that for PackageId in cargo_metadata crate it is mentioned as opaque, but for SourceId it's not. I wonder if there was a reason this crate didn't say the inner representations of SourceId is also opaque, or you've spotted some valid use cases. Thank you :)

@oli-obk
Copy link
Owner

oli-obk commented Jun 26, 2023

That's just an oversight. We should document it as opaque, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants