Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long running network requests causing a crash. #316

Merged
merged 2 commits into from
May 11, 2022

Conversation

JayNewstrom
Copy link
Contributor

Fixes #315

Description:

Testing details:

  • Verified basic functionality of change
  • Added tests

Other considerations:

  • Has security implications
  • Has UX changes
RESOLVES:

OKTA-XXXXX

Primary Reviewer(s):

Additional Reviewers:
Security Reviewer(s) (@ okta/rex-team if necessary):
UX Reviewer(s) (if necessary):

Copy link

@arvindkrishnakumar-okta arvindkrishnakumar-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@JayNewstrom JayNewstrom merged commit 65a9123 into master May 11, 2022
@JayNewstrom JayNewstrom deleted the jn-fix-long-running-crash branch May 11, 2022 16:28
@JayNewstrom
Copy link
Contributor Author

Released to maven central as 1.2.5

@idomo1
Copy link

idomo1 commented May 13, 2022

Thanks for getting this out so quickly, it seems to have fixed the issue 🙂

1 similar comment
@idomo1
Copy link

idomo1 commented May 13, 2022

Thanks for getting this out so quickly, it seems to have fixed the issue 🙂

@JayNewstrom
Copy link
Contributor Author

Happy to hear! Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when app backgrounded during login/logout
3 participants