Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKTA-488271 Sleep and retry when crypto operations fail. #311

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

JayNewstrom
Copy link
Contributor

@JayNewstrom JayNewstrom commented Apr 12, 2022

See https://github.com/google/tink/blob/cb814f1e1b69caf6211046bee083a730625a3cf9/java_src/src/main/java/com/google/crypto/tink/integration/android/AndroidKeystoreAesGcm.java for influence.

Description:

Testing details:

  • Verified basic functionality of change
  • Added tests

Other considerations:

  • Has security implications
  • Has UX changes
RESOLVES:

OKTA-XXXXX

Primary Reviewer(s):

Additional Reviewers:
Security Reviewer(s) (@ okta/rex-team if necessary):
UX Reviewer(s) (if necessary):

Fixes #310

@JayNewstrom JayNewstrom merged commit 581d70c into master Apr 13, 2022
@JayNewstrom JayNewstrom deleted the jn-OKTA-488271-retry branch April 13, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Exception: android.security.keystore.KeyStoreConnectException thrown by Huawei Android 10 devices
2 participants