feat: Add pre-commit hook for golangci-lint
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
ojaswa1942
requested changes
Oct 11, 2021
There was a problem hiding this comment.
@iamrajiv Please find the comments below:
- I'm not sure of the changes made to README file, can you describe the intended changes?
- Similarly for codesee-arch-diagram.yml
- I tried to commit after making some changes but could not see any pre-commit process being triggered. Request you to kindly have a look again or add proper documentation / steps for the same
|
@ojaswa1942 I formatted README and codesee-arch-diagram.yml using Prettier. No content has been changed only formatted and removed indentations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11
.gitignoregolangci-lint