Removed unnecessary assignments. #5045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disservin
requested changes
Feb 10, 2024
Disservin
approved these changes
Feb 10, 2024
I'm fine with the change as long as its compliant with the existing code style. According to .clang-format this is, but at first visual glance I was unsure. |
Viren6
pushed a commit
to Viren6/Stockfish
that referenced
this pull request
Feb 12, 2024
In both search and qsearch, there are instances where we do unadjustedStaticEval = ss->staticEval = eval/bestValue = tte->eval(), but immediately after re-assign ss-static and eval/bestValue to some new value, which makes the initial assignment redundant. closes official-stockfish#5045 No functional change
Viren6
pushed a commit
to Viren6/Stockfish
that referenced
this pull request
Feb 12, 2024
In both search and qsearch, there are instances where we do unadjustedStaticEval = ss->staticEval = eval/bestValue = tte->eval(), but immediately after re-assign ss-static and eval/bestValue to some new value, which makes the initial assignment redundant. closes official-stockfish#5045 No functional change
TierynnB
pushed a commit
to TierynnB/Stockfish
that referenced
this pull request
Feb 14, 2024
In both search and qsearch, there are instances where we do unadjustedStaticEval = ss->staticEval = eval/bestValue = tte->eval(), but immediately after re-assign ss-static and eval/bestValue to some new value, which makes the initial assignment redundant. closes official-stockfish#5045 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both search and qsearch, there are instances where we do unadjustedStaticEval = ss->staticEval = eval/bestValue = tte->eval(), but immediately after re-assign ss-static and eval/bestValue to some new value. Change is to just remove the initial assignment to ss-staticEval and eval/bestValue. One consideration, although very minor is to use the ternary operator to immediately assign unadjustedStaticEval but unsure if there is a significant performance difference between that and an if block. Also when I ran 'make format', it suggested ss-staticEval some alignment whitespace to the above line = bestValue =, but I think looks worse than just ss-staticEval = bestValue = (line 1453).