Remove inline assembly

[mstembera]

I benched the AVX512, AVX2, and SSSE3 binaries compiled using gcc 13.1.0 Rev5 on Windows and measure no speed difference.
https://tests.stockfishchess.org/tests/view/64b0de3b0cdec37b957332e8
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 63520 W: 16218 L: 16030 D: 31272
Ptnml(0-2): 184, 7166, 16898, 7302, 210

No functional change
bench: 1556301

@Sopel97 What do u think?

[vondele]

Did you have a look on godbolt testcase that is mentioned in the comment? https://godbolt.org/z/7EWqrYq51

For reference, our current pre-release binaries can be compiled with gcc 11 on Linux, and gcc 13 on windows (x86)

[cj5716]

I suggest benchmark on VNNI512 / AVXVNNI architectures also, given that the ASM benefits VNNI more.

[mstembera]

@vondele I don't trust myself to read the godbolt assembly well enough to tell if it's optimal or not spilling registers. Which is why I ask for @Sopel97 opinion. I should also be able to test using gcc 11 (but on Windows) if it's useful to know. Are the compilers for the pre-release binaries the same as what fishtest uses?

@cj5716 I should be able to test VNNI512 but don't have access to AVXVNNI hardware. Where does the more benefit for VNNI information come from?

[cj5716]

@vondele I don't trust myself to read the godbolt assembly well enough to tell if it's optimal or not spilling registers. Which is why I ask for @Sopel97 opinion. I should also be able to test using gcc 11 (but on Windows) if it's useful to know. Are the compilers for the pre-release binaries the same as what fishtest uses?

@cj5716 I should be able to test VNNI512 but don't have access to AVXVNNI hardware. Where does the more benefit for VNNI information come from?

There is VNNI specific ASM in the code that has fewer instructions, which is why I think benchmarking on VNNI is important.

[Sopel97]

I can't replicate any register spilling issues anymore, and I trust the test. Not sure what the representation for VNNI on fishtest is right now, probably could be benchmarked specifically here too.

[vondele]

@vondele I don't trust myself to read the godbolt assembly well enough to tell if it's optimal or not spilling registers. Which is why I ask for @Sopel97 opinion. I should also be able to test using gcc 11 (but on Windows) if it's useful to know. Are the compilers for the pre-release binaries the same as what fishtest uses?

fishtest uses what the users have installed, so it can be anything. For the pre-releases on github we have more control (yet certain limitations, not everything is available one every os).