Unused Code Cleanup #4696
Closed
Unused Code Cleanup #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesrentai
force-pushed
the
code_cleanup
branch
2 times, most recently
from
00ecbbe
to
849fefb
Compare
|
There was a large overlap with #4695 maybe you can rebase on current master and see what is remaining? |
|
The |
|
Done |
aesrentai
force-pushed
the
code_cleanup
branch
2 times, most recently
from
378f140
to
f9e46c7
Compare
vondele
reviewed
Jul 18, 2023
src/bitboard.h
Outdated
| @@ -44,8 +44,6 @@ constexpr Bitboard FileHBB = FileABB << 7; | |||
| constexpr Bitboard Rank1BB = 0xFF; | |||
| constexpr Bitboard Rank2BB = Rank1BB << (8 * 1); | |||
| constexpr Bitboard Rank3BB = Rank1BB << (8 * 2); | |||
| constexpr Bitboard Rank4BB = Rank1BB << (8 * 3); | |||
There was a problem hiding this comment.
I would probably keep those, it is not so logical to have a hole there.
vondele
reviewed
Jul 18, 2023
AUTHORS
Outdated
| @@ -45,6 +45,7 @@ candirufish | |||
| Chess13234 | |||
| Chris Cain (ceebo) | |||
| clefrks | |||
| Cody Ho | |||
There was a problem hiding this comment.
please add github handle as well.
No functional change Signed-off-by: Cody Ho <codyho@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of classical evaluation, many helper functions are no longer used and thus can be removed.
No functional change.