-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused Code Cleanup #4696
Unused Code Cleanup #4696
Conversation
00ecbbe
to
849fefb
Compare
There was a large overlap with #4695 maybe you can rebase on current master and see what is remaining? |
The |
Done |
378f140
to
f9e46c7
Compare
src/bitboard.h
Outdated
@@ -44,8 +44,6 @@ constexpr Bitboard FileHBB = FileABB << 7; | |||
constexpr Bitboard Rank1BB = 0xFF; | |||
constexpr Bitboard Rank2BB = Rank1BB << (8 * 1); | |||
constexpr Bitboard Rank3BB = Rank1BB << (8 * 2); | |||
constexpr Bitboard Rank4BB = Rank1BB << (8 * 3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably keep those, it is not so logical to have a hole there.
AUTHORS
Outdated
@@ -45,6 +45,7 @@ candirufish | |||
Chess13234 | |||
Chris Cain (ceebo) | |||
clefrks | |||
Cody Ho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add github handle as well.
No functional change Signed-off-by: Cody Ho <codyho@stanford.edu>
With the removal of classical evaluation, many helper functions are no longer used and thus can be removed.
No functional change.