Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove discounting from the multi-period model #1109

Open
Tracked by #1107
p-snft opened this issue Aug 20, 2024 · 1 comment · Fixed by #1110 · May be fixed by #1111
Open
Tracked by #1107

Remove discounting from the multi-period model #1109

p-snft opened this issue Aug 20, 2024 · 1 comment · Fixed by #1110 · May be fixed by #1111

Comments

@p-snft
Copy link
Member

p-snft commented Aug 20, 2024 •
edited
Loading

Discounting functionality is not actually needed, as we allow time series anyway. So, we can remove code without reducing functionality. (Users should be able to calculate discounting externally. On the long run, we could also provide something in oemof.tools.)
@p-snft p-snft mentioned this issue Aug 20, 2024
Open
3 tasks
@p-snft p-snft changed the title Remove discounting from the multi-period model. (Discounting functionality is not actually needed, as we allow time series anyway.) Remove discounting from the multi-period model Aug 20, 2024
@p-snft p-snft linked a pull request Aug 20, 2024 that will close this issue
Remove internal discounting for NonConvexFlow #1110
Merged
@p-snft
Copy link
Member Author

p-snft commented Aug 20, 2024 •
edited
Loading

The merged branch was not finalised. Continues in #1111.

@p-snft p-snft reopened this Aug 20, 2024
@p-snft p-snft linked a pull request Sep 3, 2024 that will close this issue
Remove internal discounting functionality #1111
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@p-snft