Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unwrap_or_revert_with should accept module as argument #414

Closed
zie1ony opened this issue Apr 25, 2024 · 0 comments · Fixed by #493
Closed

unwrap_or_revert_with should accept module as argument #414

zie1ony opened this issue Apr 25, 2024 · 0 comments · Fixed by #493

Comments

@zie1ony
Copy link
Contributor

zie1ony commented Apr 25, 2024

At the moment the way to panic when unwrapping is:

unwrap_or_revert_with(&self.env(), Overflow)

This creates a copy on env, which most of the time is not used.

Instead it could accept Module trait and get env only when needed.

unwrap_or_revert_with(&self, Overflow)
@kpob kpob linked a pull request Jun 18, 2024 that will close this issue
Improve UnwrapOrRevert interface #493
Merged
@kpob kpob closed this as completed in #493 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
⚔️Tavern 🐉
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve UnwrapOrRevert interface odradev/odra
1 participant
@zie1ony