-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show if a player's matches are being hidden #3133
Comments
hi can i take this too? |
Yes |
Are you looking to move towards typescript + hooks? If yes, i could also do the conversion for the relevant files i will be updating in this issue. Idt there are many files to change anw, so the conversion will not be too major |
Ideally the TS conversion could go in one PR and then feature change in another |
Note: We recently re-enabled showing data for pro players. So we also want to check if the player is a pro player and not show the "hidden" message if so |
Have opened a PR, do help to take a quick look whenever you're free, thanks! |
created a PR #3156, pls help to take a look whenever you're free, thanks! |
Now that we're not displaying data for players with public match data disabled, we should update the UI to show a message if this is the case.
We can check the fh_unavailable property on the player call, and display a message like: "This player has disabled public match history. If this is you, sign in to view your own data."
The text was updated successfully, but these errors were encountered: