Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements - Nice to have #48

Open
3 tasks
imranMnts opened this issue Apr 12, 2021 · 2 comments
Open
3 tasks

Improvements - Nice to have #48

imranMnts opened this issue Apr 12, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@imranMnts
Copy link
Collaborator

imranMnts commented Apr 12, 2021

Hello everyone,

Let's discuss here about the improvements which can be useful in Netwatch, to improve user/developer experience.

  • Netwatch which cannot be displayed with shake event in dev mode [iOS]
  • Not able to use Netwatch and Reactotron together (just have to change the value of enabled to switch)
  • Netwatch's FlatList lost the position when a new item was added [Android]. Known issue on React-native side link
@imranMnts imranMnts added the enhancement New feature or request label Apr 12, 2021
@imranMnts imranMnts changed the title Imrovements - Nice to have Improvements - Nice to have Apr 12, 2021
@GuillaumeHemmen
Copy link
Collaborator

Hello @imranMnts,

Just tried to have a look at this ticket with @odemolliens, I have a few questions that might need your input on your points:

Netwatch which cannot be displayed with shake event in dev mode [iOS]

What is the use case here? Completely override the shaking behaviour or open both Netwatch and RN debug menu? In the case of the former, do we want a button in Netwatch UI to open RN's debug menu if the app is in debug mode?

Not able to use Netwatch and Reactotron together (just have to change the value of enabled to switch)

What would be the proper resolution to this? Personally, I believe that you can either allow the library user to implement his own behaviour by playing with the enabled prop (e.g., disabled in debug mode so the developer can rely on Reactotron or whatever tool he's using) or maybe you foresaw a toggle button on Netwatch UI to disabled it's monitoring?

Netwatch's FlatList lost the position when a new item added [Android]. Known issue on React-native side

It seems that we can't do anything with that one, we should have a dedicated ticket to document the bug, its reproducibility and keep it on the radar.

May I suggest we do separate tickets for each feature/improvement?

@imranMnts
Copy link
Collaborator Author

Hello @GuillaumeHemmen,

Netwatch which cannot be displayed with shake event in dev mode [iOS]

  • When we are in debug mode on iOS, RN catch the shake event so Netwatch doesn't receive the event to display it.
    In my opinion, the better behaviour should be to be able to open Netwatch and RN Debug menu together.
    react-native-shake library had a similar issue, we can check their fix, it can be helpful in our case.
    I don't have a lot of time to do it for the moment but I added it to my TODO list 😉

Not able to use Netwatch and Reactotron together (just have to change the value of enabled to switch)

  • The proper resolution would be to allow the library to append interceptor to existing instead of replacing them with the new one because today for example if Reactotron registered to XHRInterceptor we can not intercept them together (Netwatch's XHRInterceptor).
    We already added a specific prop useReactotron, to allow users to see redux actions at least.

May I suggest we do separate tickets for each feature/improvement?

  • Of course, it can be very useful.
    We created this ticket to have a place where we can list/discuss interesting and feasible improvements, up to us, contributors, to create tickets for specific ones, discuss in detail and work together to put them in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants