Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve internal Types #425

Open
oscard0m opened this issue Feb 2, 2021 · 0 comments
Open

Improve internal Types #425

oscard0m opened this issue Feb 2, 2021 · 0 comments
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only

Comments

@oscard0m
Copy link
Member

oscard0m commented Feb 2, 2021

From your explanation seems like we should invest some more time on better typing this

The types for this PR are correct it's our internal types that could use improvement, and definitely worth investing improving. However, the gains vs amount of work that'd be involved would be pretty low, so I'd not say it's a super high priority (in particular because of the State type - i.e. we mark eventEmitter as optional, but don't actually check for its existence in a few places; our implementation + test suite ensure it's not undefined at runtime, but the types are not representing that properly).

We can create an issue of it (maintenance label) so at least we keep track of it. Thumbs Up if you are ok with it.

Originally posted by @oscard0m in #422 (comment)

@oscard0m oscard0m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only labels Feb 2, 2021
@gr2m gr2m changed the title To improve internal Types Improve internal Types Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR typescript Relevant to TypeScript users only
Projects
None yet
Development

No branches or pull requests

1 participant