-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Raise an error at runtime when Faraday Multipart is not installed:
- In 7bc6dd5, a warning message was added to let users know that faraday-multipart is required when using Faraday 2.0. This warning is not very helpful, and may lead to projects adding the gem to their dependencies even if they don't need it, as the faraday-multipart middleware is only used for uploading license for GitHub entrepise. This patch will avoid printing the warning unnecessarily but also display a better error message when ultimately the call to `conn.request :multipart` fails. Fix #1701
- Loading branch information
1 parent
301bb57
commit 32b73b6
Showing
5 changed files
with
34 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters