Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix for issue 6565 #6566

Closed
wants to merge 1 commit into from
Closed

quick fix for issue 6565 #6566

wants to merge 1 commit into from

Conversation

drblain
Copy link

@drblain drblain commented Jul 1, 2023 •
edited
Loading

fixes #6565
issue6565

ocornut added a commit that referenced this pull request Jul 3, 2023
@ocornut
InputText: ImGuiInputTextCallbackData::InsertChars() accept (NULL,NUL…
6417268 
…L) range, in order to conform to common idioms. (#6565, #6566, #3615)
@ocornut ocornut mentioned this pull request Jul 3, 2023
Closed
@ocornut
Copy link
Owner

ocornut commented Jul 3, 2023

Thanks for the PR.
This is analogous to #3615 we did for TextUnformatted().
Proposed fix would silently not-crash on (NULL,non-NULL) combo so I am opting for a == test there, with 6417268.
Thank you!

@ocornut ocornut closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inputtext
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support nullptr char pointers
2 participants
@drblain @ocornut