Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the font build in ImGui_ImplWin32_NewFrame #3487

Closed
actboy168 opened this issue Sep 23, 2020 · 1 comment
Closed

Check the font build in ImGui_ImplWin32_NewFrame #3487

actboy168 opened this issue Sep 23, 2020 · 1 comment
Labels
backends bug font/text

Comments

@actboy168
Copy link
Contributor

ImGui_ImplWin32_NewFrame will check if the font is built. If the Renderer releases the resource (ClearTexData) after creating the font resource, this check will fail. But it has no effect. Does this mean that this check is wrong?
ocornut added a commit that referenced this issue Jun 29, 2021
@ocornut
Fonts: Fix calling ClearTexData() (clearing CPU side font data) trigg…
23a1583 
…ering an assert in NewFrame(). (#3487) + Backends: added additional assert to facilitate detecting user understand they haven't initialized a backend.
@ocornut
Copy link
Owner

ocornut commented Jun 29, 2021

Hello @actboy168,
Sorry for my very late answer to this.
You are very right, the assert was incorrectly formulated, preventing the use of ClearTexData().
I fixed it now.
We don't expect ClearTexData() to be used by many people but still.
Note that work on #3761 when enabled will probably require user to keep CPU copy in memory.

We'll keep allow manual warming / baking of ranges + discarding of CPU/RAM data, can be useful for low-specs platforms.

@ocornut ocornut closed this as completed Jun 29, 2021
@ocornut ocornut added the bug label Jun 29, 2021
@ocornut ocornut mentioned this issue Aug 21, 2021
Closed
ocornut added a commit that referenced this issue Aug 24, 2021
@ocornut
Fonts: Fixed ImFontAtlas::ClearInputData() marking atlas as not built. (
4a7c21d 
#4455, #3487)
AnClark pushed a commit to AnClark/imgui-vst-mod that referenced this issue Aug 30, 2021
@ocornut @AnClark
Fonts: Fixed ImFontAtlas::ClearInputData() marking atlas as not built. (
5d63f1b 
ocornut#4455, ocornut#3487)
AnClark pushed a commit to AnClark/imgui-vst-mod that referenced this issue Aug 30, 2021
@ocornut @AnClark
Fonts: Fixed ImFontAtlas::ClearInputData() marking atlas as not built. (
7968c02 
ocornut#4455, ocornut#3487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backends bug font/text
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@actboy168 @ocornut