Tutorial on filtering on CPU vs. GPU #69
Conversation
- the GPU examples were previously part of tutorial_irregular_grid.ipynb - now moved to own tutorial to structure documentation better - use POP data rather than NeverWorld2 data for GPU examples - tutorial does not include performance tests - we could link to such tests later once we have them
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,5769 @@ | |||
| { | |||
There was a problem hiding this comment.
Best to use a context manager for file writing
with open('POP_SST.nc', wb) as fp:
fp.write(file.contents)
Reply via ReviewNB
| @@ -0,0 +1,5769 @@ | |||
| { | |||
There was a problem hiding this comment.
you could consider putting all of these into a dictionary (e.g. options = dict(...)) and then passing it in the next cell as Filter(..., **options)
Reply via ReviewNB
| @@ -0,0 +1,5769 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we explain more explicitly why we are filtering SST * area rather than just SST. This could be very confusing to new users.
(Side note: it seems like this should be handled by the kernel, not by the user.)
Reply via ReviewNB
|
Great work Nora! Just a few minor comments. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 7 7
Lines 719 719
=======================================
Hits 708 708
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
That makes sense to me. Use different PRs for different problems: Add tutorial with this PR; updated REGULAR/simple fixed factor with a separate PR. |
This adds a new tutorial which updates GPU examples from
tutorial_irregular_grid.ipynb:tutorial_GPU.ipynb)The tutorial does not include rigorous performance tests (as planned in #45), but rather cleans up an existing tutorial that shows how to filter on CPUs vs. GPUs. We could later add links to the performance tests once we have them. I'm also happy to adjust this tutorial (if needed) once we have made progress on #45.