-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in react-native-vector-icons, need to apply patch with 10.1.0 version #1632
Comments
@sjkushwaha21 What problem did this solve for you? |
Hi @johnf, Changing Helped my issue. |
You could clean up your patch file by only including: diff --git a/node_modules/react-native-vector-icons/lib/object-utils.js b/node_modules/react-native-vector-icons/lib/object-utils.js
index d03b55b..712b89b 100644
--- a/node_modules/react-native-vector-icons/lib/object-utils.js
+++ b/node_modules/react-native-vector-icons/lib/object-utils.js
@@ -17,4 +17,4 @@ const omit = (obj, ...keysToOmit) => {
}, {});
};
-module.exports = { pick, omit };
+export { omit, pick }; But, this looks more like a config issue you can solve here without having to patch, CJS/ESM thing. It would be good to know what your issue was not just the fix. |
Hi @johnf, @david-gettins I am facing following issue. Please find the attachment as you requested. |
@sjkushwaha21 Can you provide the code you are using? If you can provide an entire example repository that would be even better. It looks like you are using RNVI via The error you are seeing is quite strage. |
@sjkushwaha21 If this is still an issue let me know and I'll reopen |
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
react-native-vector-icons@10.1.0
for the project I'm working on.Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: