Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/rpc: Use more go-codec friendly datastructures #1756

Closed
Yawning opened this issue May 29, 2019 · 1 comment
Closed

runtime/rpc: Use more go-codec friendly datastructures #1756

Yawning opened this issue May 29, 2019 · 1 comment
Labels
c:runtime Category: runtime p:3 Priority: nice to have

Comments

@Yawning
Copy link
Contributor

Yawning commented May 29, 2019

The Go worker needs to be able to make sense of WorkerLocalRPCCallResponse messages received from the enclave. While it is possible (with some difficulty) to parse out unit enums serialized by serde_cbor with go-codec, it's unpleasant and rather ugly.

The various message types defined in runtime/src/rpc/types.rs should be changed to have struct variants so that they are easier/cleaner to interact with on the Go side.

@Yawning Yawning added p:3 Priority: nice to have c:runtime Category: runtime labels May 29, 2019
@kostko
Copy link
Member

kostko commented Aug 12, 2019

This was fixed together with #1885.

@kostko kostko closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime Category: runtime p:3 Priority: nice to have
Projects
None yet
Development

No branches or pull requests

2 participants