Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of potential problems with dangling pointers and buffer overflows #365

Closed
1 task done
dnzbk opened this issue Aug 26, 2024 · 0 comments · Fixed by #366
Closed
1 task done

Get rid of potential problems with dangling pointers and buffer overflows #365

dnzbk opened this issue Aug 26, 2024 · 0 comments · Fixed by #366
Assignees
Labels
bug Something isn't working

Comments

@dnzbk
Copy link
Collaborator

dnzbk commented Aug 26, 2024

Is there already an issue for your problem?

  • I have checked older issues, open and closed

NZBGet Version

v24.2-stable

Platform

All

Environment

Any

Current Behavior

std::string_view::data(), doesn’t guarantee the character array will be null-terminated: FileSystem.cpp

std::to_string(*val) creates a temporary object and a dangling pointer will remain after its destruction: Extension.cpp

Expected Behavior

Potential problems with dangling pointers and buffer overflows must be resolved.

Steps To Reproduce

No response

Logs

No response

Extra information

No response

@dnzbk dnzbk added the bug Something isn't working label Aug 26, 2024
@dnzbk dnzbk self-assigned this Aug 26, 2024
@dnzbk dnzbk linked a pull request Aug 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant