Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover panel with hover mode issue #1564

Closed
vptill opened this issue Mar 26, 2024 · 3 comments · May be fixed by SamandarTemirxodjayev/goshtbor#26, SamandarTemirxodjayev/goshtbor#28 or SamandarTemirxodjayev/goshtbor#29
Labels
enhancement New feature or request needs reproduction

Comments

@vptill
Copy link

vptill commented Mar 26, 2024

Description

At present, the Popover component is configured so that its mouseenter event is limited to the HPopoverButton. This setup can lead to functionality problems; specifically, if the user's mouse movement from the button to the panel deviates slightly, the panel will close, despite the mouse being positioned over the panel.

Additional context

No response

@vptill vptill added the enhancement New feature or request label Mar 26, 2024
@moshetanzer
Copy link
Collaborator

Hi @vptill,

Can you please provide a basic reproduction of this. Not sure if I understand you?

@vptill
Copy link
Author

vptill commented Mar 27, 2024

Just create a simple Popover with hover mode and set closeDelay to 1s. When you hover on the PopoverButton the panel shows. However, if you move away from the button first, then back to the panel before it closes, the closeTimeout will still run and will close the panel, even though the users mouse is on the panel. This is because the mouseenter event is only set on the button.

Copy link
Member

@vptill It's my bad, I've removed this event in this commit: b50fbcf. I'll put it back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment