-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use eslint-webpack-plugin
#40
Conversation
BREAKING CHANGE: Use `eslint-webpack-plugin` instead of `eslint-loader` deprecated.
cache
enabled by defaultcache
enabled by default
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 21 22 +1
Branches 2 2
=========================================
+ Hits 21 22 +1
Continue to review full report at Codecov.
|
cache
enabled by defaulteslint-webpack-plugin
Do you test it before merging? Looks like module completely broken |
mines breaking too... idk where the upgrade guide is for this module... have you found a resolution or a work around? |
Looks to be a problem with the cache. If pass: eslint: {
cache: false,
}, In my I like the idea of the cache but something has gone wrong through the upgrade. |
@zoxon @toddheslin I did a quick doc for this upgrade. I believe upgrading from v2 to v3 was causing the problem. https://aznric3boi91.medium.com/update-your-nuxtjs-eslint-module-from-v2-to-v3-20b5f0bcdb68 I also created a PR to update the docs as well. nuxt/website-v2#1057 |
Awesome @rlam3 thanks for the article. Just a note for your 'after': you already destructured export default {
// Run ESLint on save
build: {
extend(config, { isDev, isClient }) {
if (isDev && isClient) {
const options = {
exclude: ['node_modules']
}
const EslintPlugin = require('eslint-webpack-plugin')
config.plugins.push(new EslintPlugin(options))
}
}
} |
Resolve #38
BREAKING CHANGE:
cache
by defaultlintDirtyModulesOnly
by defaulteslint-webpack-plugin
instead ofeslint-loader
deprecated.