Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change explore tab to collection tab #3243

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Conversation

shc261392
Copy link
Contributor

@shc261392 shc261392 commented Apr 24, 2024

Changed

  • Change explorer tab to collection tab, replacing iframe URL and icon


┆The issue is also created on Asana

Signed-off-by: James Chien <james@numbersprotocol.io>
@shc261392 shc261392 requested a review from olgahaha April 24, 2024 06:17
@shc261392 shc261392 marked this pull request as draft April 24, 2024 06:20
Signed-off-by: James Chien <james@numbersprotocol.io>
Signed-off-by: James Chien <james@numbersprotocol.io>
Signed-off-by: James Chien <james@numbersprotocol.io>
@shc261392 shc261392 marked this pull request as ready for review April 25, 2024 04:02
Signed-off-by: James Chien <james@numbersprotocol.io>
src/app/app.component.ts Show resolved Hide resolved
@@ -63,7 +63,7 @@ import { PrefetchingDialogComponent } from './onboarding/prefetching-dialog/pref
export class HomePage {
readonly initialTabIndex = 0;
private readonly afterCaptureTabIndex = 0;
private readonly exploreTabIndex = 2;
private readonly CollectionTabIndex = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming rule - start with lowercase.

}

navigateBackExploreIframe() {
this.exploreIframe?.nativeElement.contentWindow?.postMessage(
navigateBackcollectionIframe() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigateBackCollectionIframe

@@ -10,14 +10,13 @@ export class IframeService {

private readonly preferences = this.preferenceManager.getPreferences(this.id);

readonly exploreTabRefreshRequested$ = new BehaviorSubject(new Date());
readonly CollectionTabRefreshRequested$ = new BehaviorSubject(new Date());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming rule - start with lowercase.


readonly exploreTabIframeNavigateBack$ =
this._exploreTabIframeNavigateBack$.asObservable();
readonly CollectionTabIframeNavigateBack$ =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming rule - start with lowercase.

private readonly _exploreTabIframeNavigateBack$ = new ReplaySubject<boolean>(
1
);
private readonly _CollectionTabIframeNavigateBack$ =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming rule - start with lowercase.

Signed-off-by: James Chien <james@numbersprotocol.io>
@shc261392 shc261392 requested a review from olgahaha April 25, 2024 07:45
@shc261392 shc261392 merged commit d82d8b4 into master Apr 25, 2024
9 checks passed
@shc261392 shc261392 deleted the feature-collection-tab branch April 25, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants