-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat v230223 v230310 special provider for photos taken from capture app #2667
Merged
bafu
merged 10 commits into
milestone-v230223-with-v230310
from
feat-v230223-v230310-special-provider-for-photos-taken-from-capture-app
Apr 2, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
661cef9
refactor: rename WebCryptoApiSignatureProvider to CaptureAppWebCrypto…
sultanmyrza d315e37
copy keys from WebCryptoApiSignatureProvider to CaptureAppWebCryptoAp…
sultanmyrza 71659da
add cameraSource field to Media interface
sultanmyrza 6812720
refactor(migration.service): use CameraSource.Camera as default value
sultanmyrza 16a5a5f
feat(signature-provider): add method idFor
sultanmyrza d01f37f
refactor(collector.service): pass CameraSource as extra param
sultanmyrza 86bc3ba
refactor(camera.service): pass CameraSource as extra param
sultanmyrza 62c07d6
refactor(go-pro-media.service): pass CameraSource as extra param
sultanmyrza 590d974
refactor(custom-camera): pass CameraSource as extra param
sultanmyrza 7a06256
set SignedMessage.record based on camera source
sultanmyrza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sultanmyrza can you please share with me if photo upload is involved in this PR? According to the source code, I think it is mainly for the photos taken from capture app. However, it mentioned "uploadToCapture" so that I want to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tammyyang, In this PR I changed uploadToCapture parameters.
Now I pass extra parameter curCaptureCameraSource that can be PHOTO (when picked from gallery) or CAMERA (when taken photo from camera)
Then I use that parameter when making decision.
If curCaptureCameraSource = PHOTO => UploaderWebCryptoApiSignatureProvider
if curCaptureCameraSource = CAMERA => CaptureAppWebCryptoApiSignatureProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Photo upload is involved in way that we pass extra param (PHOTO or CAMERA)