Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated default options in EGSnrc documentation #959

Open
ftessier opened this issue Feb 7, 2023 · 1 comment · May be fixed by #960
Open

Outdated default options in EGSnrc documentation #959

ftessier opened this issue Feb 7, 2023 · 1 comment · May be fixed by #960

Comments

@ftessier
Copy link
Member

ftessier commented Feb 7, 2023

Default options for transport parameters in the EGSnrc manual PIRS-701 needs updating. For example, @dworogers noted the following outdated passage regarding the default photon cross section:

In the current version of EGSnrc, the user has the option to use photon
cross section data other than the default Storm & Israel data. To do this,
the user must set the character variable photon xsections (part of the
COMIN/MEDIA common block) to the name of the cross section data to use.
Cross sections included with the EGSnrc distribution are: i

  1. the Evaluated Photon Data Library[44] (set photon xsections= "epdl")
  2. XCOM data from Berger & Hubbell[37] (set photon xsections= "xcom" –
    also the default in the absence of any input)

The linked passage is incorrect, given that the default was changed in 2012:

$ cvs diff -r1.48 -r1.49 src/egsnrc.macros
Index: src/egsnrc.macros
===================================================================
RCS file: /home/cvsroot/HEN_HOUSE/src/egsnrc.macros,v
retrieving revision 1.48
retrieving revision 1.49
diff -r1.48 -r1.49
2c2
< " $Id: egsnrc.macros,v 1.48 2012/10/04 23:15:00 Exp $ "
---
> " $Id: egsnrc.macros,v 1.49 2012/10/05 00:19:51 Exp $ "
2252c2252
< REPLACE {$XDATA-DEFAULT} WITH {'si'}
---
> REPLACE {$XDATA-DEFAULT} WITH {'xcom'}
@ftessier ftessier added this to the Release 2024 milestone Feb 7, 2023
@ftessier ftessier changed the title Outdated content in EGSnrc manual (PIRS-701) Outdated content in EGSnrc documentation Feb 10, 2023
@ftessier
Copy link
Member Author

ftessier commented Feb 10, 2023

Upon updating PIRS-701 a lot of outdated defaults EGSnrc transport parameters was revealed across all applications and inside the code, which should all be updated.

@ftessier ftessier linked a pull request Feb 10, 2023 that will close this issue
@ftessier ftessier linked a pull request Feb 11, 2023 that will close this issue
@ftessier ftessier self-assigned this Feb 15, 2023
@ftessier ftessier changed the title Outdated content in EGSnrc documentation Outdated default options in EGSnrc documentation Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant