fix(parse): Crash on strings that parse to having no host

Fixes: #35
npm · Jul 7, 2018 · c931482 · c931482 · jaydenseric · Jul 7, 2018
1 parent b7b18a9
commit c931482
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -58,7 +58,7 @@ function fromUrl (giturl, opts) {
         project = decodeURIComponent(shortcutMatch[3])
         defaultRepresentation = 'shortcut'
       } else {
-        if (parsed.host !== gitHostInfo.domain && parsed.host.replace(/^www[.]/, '') !== gitHostInfo.domain) return
+        if (parsed.host && parsed.host !== gitHostInfo.domain && parsed.host.replace(/^www[.]/, '') !== gitHostInfo.domain) return
         if (!gitHostInfo.protocols_re.test(parsed.protocol)) return
         if (!parsed.path) return
         var pathmatch = gitHostInfo.pathmatch

diff --git a/test/basic.js b/test/basic.js
@@ -25,5 +25,12 @@ test('basic', function (t) {
   t.is(HostedGit.fromUrl('gist:123').https(), 'git+https://gist.github.com/123.git', 'non-user shortcut')
 
   t.is(HostedGit.fromUrl('git+https://github.com:foo/repo.git#master').https(), 'git+https://github.com/foo/repo.git#master', 'scp style urls are upgraded')
+
+  t.is(HostedGit.fromUrl(''), undefined, 'empty strings are not hosted')
+  t.is(HostedGit.fromUrl(null), undefined, 'null is not hosted')
+  t.is(HostedGit.fromUrl(), undefined, 'no value is not hosted')
+  t.is(HostedGit.fromUrl('git+file:///foo/bar'), undefined, 'url that has no host')
+  t.is(HostedGit.fromUrl('github.com/abc/def/'), undefined, 'forgot the protocol')
+  t.is(HostedGit.fromUrl('completely-invalid'), undefined, 'not a url is not hosted')
   t.end()
 })