Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in npm access usage #7370

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix: typo in npm access usage #7370

merged 2 commits into from
Apr 12, 2024

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Apr 12, 2024

Add closing ] for optional owner parameter.

@mbtools mbtools requested a review from a team as a code owner April 12, 2024 15:13
@wraithgar
Copy link
Member

Thanks! This is one of the last places in npm where those cli output params are hand-crafted which means we get bugs like this.

@wraithgar
Copy link
Member

npm run snap should update the test snapshots, you can commit those changes and this PR should go green.

@mbtools
Copy link
Contributor Author

mbtools commented Apr 12, 2024

On my windows machine, updating the snapshots changes all of them to different EOL format and also fails from tests bcs of missing shell.

I edited the docs snapshot manually. I hope that's sufficient.

@wraithgar wraithgar merged commit 2a80dab into npm:latest Apr 12, 2024
20 checks passed
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
@mbtools mbtools deleted the patch-2 branch April 13, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants