Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hosted-git-info to parse registry urls #5761

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

lukekarrys
Copy link
Contributor

Previously this was using new URL which would fail on some urls that
hosted-git-info is able to parse. But if we still get a url that can't
be parsed, we now set it to be removed from the tree instead of
erroring.

Fixes: #5278

@lukekarrys lukekarrys requested a review from a team as a code owner October 27, 2022 00:32
@lukekarrys lukekarrys marked this pull request as draft October 27, 2022 00:33
@lukekarrys
Copy link
Contributor Author

Converting to a draft until npm/hosted-git-info#177 is landed and published.

Previously this was using `new URL` which would fail on some urls that
`hosted-git-info` is able to parse. But if we still get a url that can't
be parsed, we now set it to be removed from the tree instead of
erroring.

Fixes: #5278
@lukekarrys lukekarrys marked this pull request as ready for review October 27, 2022 22:42
@wraithgar wraithgar merged commit 26f3d0b into release/v8 Nov 1, 2022
@wraithgar wraithgar deleted the lk/git-ssh-urls-v8 branch November 1, 2022 16:45
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Feb 6, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this pull request Feb 6, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/meta-openembedded that referenced this pull request Feb 6, 2023
Source: meta-openembedded
MR: 124675
Type: Integration
Disposition: Merged from meta-openembedded
ChangeID: 278ec08
Description:

* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
nmbath pushed a commit to victronenergy/meta-openembedded that referenced this pull request Feb 10, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
(cherry picked from commit 278ec08)
nmbath pushed a commit to victronenergy/meta-openembedded that referenced this pull request Feb 24, 2023
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
(cherry picked from commit 278ec08)
sgunin pushed a commit to sgunin/oe-meta-openembedded-contrib that referenced this pull request Mar 17, 2024
* 16.18.0 (npm 8.19.2) introduced a regression in git+ssh urls
  - nodejs/node#44992
  - npm/cli#5761

https://nodejs.org/ko/blog/release/v16.19.0/

License-Update: Clarify vendored OpenSSL Toolkit is OpenSSL and SSLeay
License-Update: JS Foundation -> OpenJS Foundation

nodejs/node@e7ed56f

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants