Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: name and version description change #5753

Merged
merged 7 commits into from
Nov 1, 2022
Merged

docs: name and version description change #5753

merged 7 commits into from
Nov 1, 2022

Conversation

dominikgorczyca
Copy link

Reducing redundancy by deleting repeated code and changing other slight things about those two fields.

Reducing redundancy by deleting repeated code and changing other slight things about those two fields.
@dominikgorczyca dominikgorczyca requested a review from a team as a code owner October 26, 2022 16:37
Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! There's some ongoing discussion about how to handle the required-ness of name and version. I think there's a little more nuance than them being strictly required or optional. npm/documentation#134

Can you update this PR to remove those parts of the changes?

@dominikgorczyca
Copy link
Author

Not sure if this is what you mean, but I changed some things about requiredness... Is there something else I should delete?

@lukekarrys
Copy link
Contributor

Thanks for the updates! I think this looks good now.

@wraithgar wraithgar merged commit bd92aa0 into npm:release/v8 Nov 1, 2022
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
@dominikgorczyca dominikgorczyca deleted the patch-1 branch November 3, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants