Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use default service dns instead of custom dns and ingress controller #15

Open
runitmisra opened this issue Dec 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@runitmisra
Copy link
Contributor

Users should have the option to not use ingress to pass traffic through, utilizing the default service dns instead of a custom domain. This would help remove dependency on passing traffic through ingress controller removing possible bottlenecks in single cluster environments.

  • Add a host <service name>.<namespace> in the CSR sent to CAs on every enroll so that default dns can be used for tls
  • Wherever possible, add option for the user to provide default dns instead of hlf domain, eg. - CORE_PEER_ADDRESS_EXTERNALENDPOINT, in cryptogen configtx file, etc. Basically HLF Domain should be optional wherever possible.
@tittuvarghese
Copy link
Member

This is a good feature for a closed loop network / benchmarking / test environments. It can create problems when multi-dc or multi-cluster mode deployment happens as the resolution fails.

@tittuvarghese tittuvarghese added the enhancement New feature or request label Dec 21, 2023
@jithindevasia
Copy link
Member

jithindevasia commented Jan 5, 2024

@runitmisra Try out the 1.1.0 by adjusting the values file accordingly. Ie, instead of providing a domain.com as the hlf_domain, just use namespace.svc.cluster.local. Example, for ica-org1 deployment, the k8s service name will get rendered as ica-org1. Since the CSR is for ‘ica-org1’ and ica-org1.namespace.svc.cluster.local it will be reachable within the cluster without ingress controller or additional dns entries. All you need to do is adjust the values accordingly. Please try it out and update where it is breaking with logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants