Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code for get-subscribers method(Node.js SDK) #316

Closed
wants to merge 0 commits into from

Conversation

codingis4noobs2
Copy link
Contributor

Closes #315

Before:
image

After:
image

@codingis4noobs2
Copy link
Contributor Author

@sumitsaurabh927 Have a look here sir
If anything is to be changed, let me know 🙂

@codingis4noobs2
Copy link
Contributor Author

@BiswaViraj awaiting approval/feedback 🙂

@@ -1,5 +1,155 @@
---
openapi: get /v1/subscribers
openapi: get /v1/subscribers/{subscriberId}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openapi: get /v1/subscribers/{subscriberId}
openapi: get /v1/subscribers

I think this will not need the subscriberId
@sumitsaurabh927 can you confirm this?

Copy link
Contributor

@sumitsaurabh927 sumitsaurabh927 Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not needed!

@ainouzgali
Copy link
Contributor

Also, the function is novu.subscribers.list() and not get :)

@unicodeveloper
Copy link
Contributor

Any updates here? @codingis4noobs2

@codingis4noobs2
Copy link
Contributor Author

Hey @unicodeveloper , the suggested changes will be done by today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code for get-subscribers which uses Novu Node.js SDK
5 participants