Feature [RM66] Cell Short Description #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short descriptions are shown in cells instead of full descriptions if they are available.
| } | ||
| .padding() | ||
| } | ||
| .buttonStyle(PlainButtonStyle()) | ||
| } | ||
|
|
||
| func description(for character: Character) -> String { | ||
| if let c = character as? ShortCharacterDescription { |
There was a problem hiding this comment.
Try not to use one letter variables, Usually there will be setting in swift lint that will prevent you from that. you can use char or. event `character.
MiWierzbinski
approved these changes
Aug 9, 2021
| } | ||
| .padding() | ||
| } | ||
| .buttonStyle(PlainButtonStyle()) | ||
| } | ||
|
|
||
| func description(for character: Character) -> String { |
There was a problem hiding this comment.
This logic should not. be in view layer. This should reside in ViewModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66064062
Short descriptions are shown in cells instead of full descriptions if they are available.