Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for DragonFlyBSD. #592

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

waywardmonkeys
Copy link
Contributor

The correct target_os for this is dragonfly, not dragonflybsd.

This was introduced in 8399e41.

The correct `target_os` for this is `dragonfly`, not `dragonflybsd`.

This was introduced in 8399e41.
@waywardmonkeys
Copy link
Contributor Author

This can be seen by doing a build with nightly after the check-cfg feature was added.

@0xpr03
Copy link
Member

0xpr03 commented Jun 26, 2024

Fix is valid as documented per https://doc.rust-lang.org/reference/conditional-compilation.html#target_os

Thanks!

@0xpr03 0xpr03 merged commit 39e8d1b into notify-rs:main Jun 26, 2024
13 checks passed
@0xpr03 0xpr03 mentioned this pull request Jun 26, 2024
6 tasks
@waywardmonkeys waywardmonkeys deleted the fix-dragonfly-target-os branch June 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants