quic: crash when connecting to ipv6 endpoint

[jasnell]

Just opening as a reminder to fix...

There's currently an error when attempting to call QuicSocket.prototype.connect() to connect to an ipv6 endpoint.

  client = createSocket({ endpoint: { type: 'udp6' }, client: {
    key,
    cert,
    ca,
    alpn: kALPN,
    preferredAddressPolicy: 'accept' } });

  const req = client.connect({
    address: 'localhost',
    port: endpoint.address.port,
    servername: 'localhost',
//    type: 'udp6',
  });

Uncommenting type above allows the code to work

NOTE: The test started as a child_process using these flags: [ '--expose-internals', '--no-warnings' ] Use NODE_SKIP_FLAG_CHECK to run the test with the original flags.
QuicSocket (0:3) New QuicSocket created.
QuicSocket (0:3) Adding preferred endpoint.
QuicSocket (0:3) Adding endpoint.
QuicSocket (0:3) Endpoint :::64661 bound
QuicSocket (0:3) Endpoint :::12346 bound
QuicSocket (0:11) New QuicSocket created.
QuicSocket (0:11) Adding preferred endpoint.
QuicSocket (0:3) Starting to listen.
QuicSocket (0:11) Endpoint :::64662 bound
cmd - vcbuild  experimental-quic - Release\node  test\sequential\test-quic-preferred-address-ipv6.js[1900]: c:\users\jasne\projects\quic\src\quic\node_quic_session.cc:3785: Assertion `(SocketAddress::ToSockAddr(family, *address, port, &addr)) != nullptr' failed.
 1: 00007FF7CE156D4F node::DumpBacktrace+143 [c:\users\jasne\projects\quic\src\debug_utils.cc]:L274
 2: 00007FF7CE0CE346 node::Abort+22 [c:\users\jasne\projects\quic\src\node_errors.cc]:L247
 3: 00007FF7CE0CE6F3 node::Assert+131 [c:\users\jasne\projects\quic\src\node_errors.cc]:L264
 4: 00007FF7CE015C72 node::quic::`anonymous namespace'::NewQuicClientSession+2162 [c:\users\jasne\projects\quic\src\quic\node_quic_session.cc]:L3785
 5: 00007FF7CEBFAFB0 v8::internal::FunctionCallbackArguments::Call+336 [c:\users\jasne\projects\quic\deps\v8\src\api\api-arguments-inl.h]:L159
 6: 00007FF7CEBFA1D0 v8::internal::`anonymous namespace'::HandleApiCallHelper<0>+624 [c:\users\jasne\projects\quic\deps\v8\src\builtins\builtins-api.cc]:L113
 7: 00007FF7CEBFA668 v8::internal::Builtin_Impl_HandleApiCall+296 [c:\users\jasne\projects\quic\deps\v8\src\builtins\builtins-api.cc]:L141
 8: 00007FF7CEBFA43E v8::internal::Builtin_HandleApiCall+62 [c:\users\jasne\projects\quic\deps\v8\src\builtins\builtins-api.cc]:L129
 9: 00007FF7CF2F4A9D Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit+61 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L16934
10: 00007FF7CF2802DB Builtins_InterpreterEntryTrampoline+187 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L1234
11: 00007FF7CF2802DB Builtins_InterpreterEntryTrampoline+187 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L1234
12: 00007FF7CF279ED9 Builtins_ArgumentsAdaptorTrampoline+185 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L341
13: 00007FF7CF2802DB Builtins_InterpreterEntryTrampoline+187 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L1234
14: 00007FF7CF27DE3E Builtins_JSEntryTrampoline+94 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L931
15: 00007FF7CF27DA2C Builtins_JSEntry+204 [C:\Users\jasne\Projects\quic\out\Release\obj\v8_snapshot\embedded.S]:L892
16: 00007FF7CEB0E9A2 v8::internal::`anonymous namespace'::Invoke+962 [c:\users\jasne\projects\quic\deps\v8\src\execution\execution.cc]:L268
17: 00007FF7CEB0E239 v8::internal::Execution::Call+185 [c:\users\jasne\projects\quic\deps\v8\src\execution\execution.cc]:L360
18: 00007FF7CEC3C610 v8::Function::Call+608 [c:\users\jasne\projects\quic\deps\v8\src\api\api.cc]:L4893
19: 00007FF7CE17E008 node::InternalMakeCallback+504 [c:\users\jasne\projects\quic\src\api\callback.cc]:L161
20: 00007FF7CE1745A3 node::AsyncWrap::MakeCallback+163 [c:\users\jasne\projects\quic\src\async_wrap.cc]:L744
21: 00007FF7CE15E225 node::cares_wrap::`anonymous namespace'::AfterGetAddrInfo+901 [c:\users\jasne\projects\quic\src\cares_wrap.cc]:L1875
22: 00007FF7CE1AB1FA uv__getaddrinfo_done+874 [c:\users\jasne\projects\quic\deps\uv\src\win\getaddrinfo.c]:L233
23: 00007FF7CE1BB737 uv__work_done+183 [c:\users\jasne\projects\quic\deps\uv\src\threadpool.c]:L313
24: 00007FF7CE1B738B uv_process_async_wakeup_req+155 [c:\users\jasne\projects\quic\deps\uv\src\win\async.c]:L98
25: 00007FF7CE1B68CC uv_process_reqs+556 [c:\users\jasne\projects\quic\deps\uv\src\win\req-inl.h]:L195
26: 00007FF7CE1B6B54 uv_run+244 [c:\users\jasne\projects\quic\deps\uv\src\win\core.c]:L520
27: 00007FF7CE0864C3 node::NodeMainInstance::Run+387 [c:\users\jasne\projects\quic\src\node_main_instance.cc]:L138
28: 00007FF7CE103E28 node::Start+296 [c:\users\jasne\projects\quic\src\node.cc]:L1058
29: 00007FF7CDED4BFC wmain+444 [c:\users\jasne\projects\quic\src\node_main.cc]:L72
30: 00007FF7CF40FD0C __scrt_common_main_seh+268 [d:\agent\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl]:L288
31: 00007FFAF4777BD4 BaseThreadInitThunk+20
32: 00007FFAF5E8CED1 RtlUserThreadStart+33