Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] https: fix connection checking interval not clearing on server close #50194

Closed
wants to merge 2 commits into from
Closed

[v18.x backport] https: fix connection checking interval not clearing on server close #50194

wants to merge 2 commits into from

Commits on Oct 16, 2023

  1. https: fix connection checking interval not clearing on server close 

    The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.

fixes: nodejs#48373

Backport-PR-URL: nodejs#50194
    @Linkgoron @H4ad
    Linkgoron authored and H4ad committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4ad67a3 View commit details
    Browse the repository at this point in the history

  2. fixup! https: fix connection checking interval not clearing on server… 

    … close

Backport-PR-URL: nodejs#50194
    @Linkgoron @H4ad
    Linkgoron authored and H4ad committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9399efb View commit details
    Browse the repository at this point in the history